search

kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
993 stars 797 forks source link

Add nodeComponentOnly parameter to helm chart #2106

Closed AndrewSirenko closed 3 months ago

AndrewSirenko commented 3 months ago

Is this a bug fix or adding new feature?

/feature

What is this PR about? / Why do we need it?

Add a nodeComponentOnly parameter to helm chart.

What testing is done?

Here are helm template results with and without setting nodeComponentOnly=true, as well as the diff (as textfiles because gists don't support yaml):

nodeComponentOnlyTemplate.txt defaultChart.txt diff.txt

Also deployed the driver with this setting:

helm upgrade \
  --install aws-ebs-csi-driver \
  --namespace kube-system \
  $HOME/workplace/aws-ebs-csi-driver/charts/aws-ebs-csi-driver \
  --values "$HOME/workplace/tools/driver-testing/driver-up/custom_values.yaml" \
  --set nodeComponentOnly=true

Release "aws-ebs-csi-driver" does not exist. Installing it now.
NAME: aws-ebs-csi-driver
LAST DEPLOYED: Fri Aug  9 18:51:28 2024
NAMESPACE: kube-system
STATUS: deployed
REVISION: 1
...

❯ kubectl get pod -n kube-system -l "app.kubernetes.io/name=aws-ebs-csi-driver,app.kubernetes.io/instance=aws-ebs-csi-driver"
NAME                 READY   STATUS    RESTARTS   AGE
ebs-csi-node-4cxvv   3/3     Running   0          12s
ebs-csi-node-57f2r   3/3     Running   0          12s
ebs-csi-node-kss7k   3/3     Running   0          12s
ebs-csi-node-tq9sv   3/3     Running   0          12s
github-actions[bot] commented 3 months ago

Code Coverage Diff

This PR does not change the code coverage

AndrewSirenko commented 3 months ago

/hold

For better name. Leaning towards nodeDriverOnly

Edit: Connor proposed nodeComponentOnly, I'm a fan.

AndrewSirenko commented 3 months ago

/unhold

Name found

ConnorJC3 commented 3 months ago

/retest /lgtm

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)~~ [torredil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment