search

kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
998 stars 800 forks source link

Backout VAC auto-enable #2118

Closed ConnorJC3 closed 3 months ago

ConnorJC3 commented 3 months ago

Is this a bug fix or adding new feature?

Revert of #2114

What is this PR about? / Why do we need it?

Based on testing, we don't want to auto-enable VAC until the sidecars we ship with the driver support beta API version instead of alpha. We expect that to happen in the next upstream external-resizer/external-provisioner releases but not before our August release.

What testing is done?

N/A

github-actions[bot] commented 3 months ago

Code Coverage Diff

File Old Coverage New Coverage Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/cloud/devicemanager/allocator.go 100.0% 93.3% -6.7
AndrewSirenko commented 3 months ago

/approve

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)~~ [AndrewSirenko] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment