search

kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
998 stars 800 forks source link

Add reservedVolumeAttachments to windows nodes #2134

Closed AndrewSirenko closed 2 months ago

AndrewSirenko commented 2 months ago

Is this a bug fix or adding new feature?

Bug Fix

What is this PR about? / Why do we need it?

It seems that specifying a custom reservedVolumeAttachments parameter will not propagate to windows Nodes.

What testing is done?

Helm

k8s-ci-robot commented 2 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ElijahQuinones commented 2 months ago

/lgtm

k8s-ci-robot commented 2 months ago

@ElijahQuinones: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/2134#issuecomment-2338671269): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)~~ [ConnorJC3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment