kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
998 stars 800 forks source link

Add support for outpost nodegroups to `make cluster/create` #2135

Closed ConnorJC3 closed 2 months ago

ConnorJC3 commented 2 months ago

Is this a bug fix or adding new feature?

New feature for Maklefile

What is this PR about? / Why do we need it?

Adds the ability to create an outposts nodegroup when creating an eksctl cluster through make cluster/create, which greatly simplifies debugging outpost-only features of the driver.

What testing is done?

Manually tested with:

export CLUSTER_TYPE=eksctl
export AWS_REGION=us-east-1
export AWS_AVAILABILITY_ZONES=us-east-1a,us-east-1b
export OUTPOST_ARN="arn:aws:outposts:us-east-1:REDACTED:outpost/op-REDACTED"
export OUTPOST_INSTANCE_TYPE=c5.xlarge

make cluster/create
ElijahQuinones commented 2 months ago

Looks good to me tested these changes to the make file on teams outpost account and they worked for me as well.

/lgtm

k8s-ci-robot commented 2 months ago

@ElijahQuinones: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/2135#issuecomment-2338670209): >Looks good to me tested these changes to the make file on teams outpost account and they worked for me as well. > >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
AndrewSirenko commented 2 months ago

/approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)~~ [AndrewSirenko] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment