search

kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
998 stars 800 forks source link

Add permissions to all GitHub actions #2143

Closed ConnorJC3 closed 2 months ago

ConnorJC3 commented 2 months ago

Is this a bug fix or adding new feature?

"Bug fix"

What is this PR about? / Why do we need it?

The kubernetes-sigs GitHub org was moved to a GitHub enterprise account, changing the default permissions for actions. Explicitly define the permissions we need in each action so they continue to run successfully.

What testing is done?

CI

ConnorJC3 commented 2 months ago

Suggestion: Could we follow the best-practice of commenting why you need each permission as seen in the kubernetes-sigs/karpenter project?

Added comments to all the permissions that aren't read: contents. I can add them there if people want, but as that permissions is necessary to checkout the repo it would just be # Checkout repo on every action.

torredil commented 2 months ago

/approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)~~ [torredil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ElijahQuinones commented 2 months ago

/lgtm

k8s-ci-robot commented 2 months ago

@ElijahQuinones: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/2143#issuecomment-2353213286): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.