search

kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
998 stars 800 forks source link

[release-1.35] Fix csi-attacher crash due to VAC feature gate on wrong sidecar #2148

Closed ConnorJC3 closed 2 months ago

ConnorJC3 commented 2 months ago

Is this a bug fix or adding new feature?

Bug fix

What is this PR about? / Why do we need it?

VAC feature gate is applied to the wrong sidecar (attacher instead of resizer), fix that and push a new Helm release.

What testing is done?

Manual

github-actions[bot] commented 2 months ago

Code Coverage Diff

File Old Coverage New Coverage Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/cloud/devicemanager/allocator.go 93.3% 100.0% 6.7
ElijahQuinones commented 2 months ago

/lgtm thank you !

k8s-ci-robot commented 2 months ago

@ElijahQuinones: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/2148#issuecomment-2353518992): >/lgtm >thank you ! > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
torredil commented 2 months ago

/approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/release-1.35/OWNERS)~~ [torredil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AndrewSirenko commented 2 months ago

All containers come up on 1.31 cluster:

❯ k get pod -n kube-system ebs-csi-controller-dd646df8-6nrrl -o yaml | g VolumeAttributes
    - --feature-gates=VolumeAttributesClass=true
    - --feature-gates=VolumeAttributesClass=true