search

kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
998 stars 800 forks source link

Update VolumeAttributesClass example to beta #2150

Closed AndrewSirenko closed 2 months ago

AndrewSirenko commented 2 months ago

Is this a bug fix or adding new feature? Update

What is this PR about? / Why do we need it?

The current ModifyVolume example will not work with aws-ebs-csi-driver version >= v1.35.0 due to the VolumeAttributesClass object upgrading to v1beta1 in Kubernetes v1.31 and external sidecars.

Also decreased volume size and iops to be more frugal.

Am open to updating modify-volume.md further to remove steps that are no longer relevant for aws-ebs-csi-driver >= 1.35.0 (i.e. adding feature gate on sidecars manually instead of relying on our helm chart)

What testing is done? Going through example manually

github-actions[bot] commented 2 months ago

Code Coverage Diff

This PR does not change the code coverage

AndrewSirenko commented 2 months ago

/retest

ElijahQuinones commented 2 months ago

/lgtm Thanks for updating the docs Drew

k8s-ci-robot commented 2 months ago

@ElijahQuinones: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/2150#issuecomment-2374360486): >/lgtm >Thanks for updating the docs Drew > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)~~ [ConnorJC3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment