kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
998 stars 800 forks source link

feat: Added new policy to PodDisruptionBudget #2159

Closed peterabarr closed 2 months ago

peterabarr commented 2 months ago

Is this a bug fix or adding new feature?

New feature

What is this PR about? / Why do we need it?

I opened an issue #2146 asking for support for the new unhealthyPodEvictionPolicy for the PDB in the chart.

What testing is done? I generated a helm template file locally and tried to set unhealthyPodEvictionPolicy in the chart values to AlwaysAllow with a successful output.

Screen Shot 2024-09-30 at 16 00 18 PM

k8s-ci-robot commented 2 months ago

Welcome @peterabarr!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 months ago

Hi @peterabarr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
AndrewSirenko commented 2 months ago

/ok-to-test

Thanks for the contribution, we'll review it once it is undrafted (marked ready for review)!

I'm pre-emptively marking it ok-to-test so you get CI feedback.

AndrewSirenko commented 2 months ago

/retest

Looks like an unrelated flake

peterabarr commented 2 months ago

@AndrewSirenko Hey thanks I've just done a local test myself and posted it inside the PR as well as taking it out of draft now!

github-actions[bot] commented 2 months ago

Code Coverage Diff

This PR does not change the code coverage

AndrewSirenko commented 2 months ago

/lgtm

Works with the following:

helm upgrade \
  --install aws-ebs-csi-driver \
  --namespace kube-system \
  $HOME/workplace/aws-ebs-csi-driver/charts/aws-ebs-csi-driver \
  --values "..." \
  --set controller.podDisruptionBudget.unhealthyPodEvictionPolicy=AlwaysAllow
spec:                                                                                                                              │
│   maxUnavailable: 1                                                                                                                │
│   selector:                                                                                                                        │
│     matchLabels:                                                                                                                   │
│       app: ebs-csi-controller                                                                                                      │
│       app.kubernetes.io/instance: aws-ebs-csi-driver                                                                               │
│       app.kubernetes.io/name: aws-ebs-csi-driver                                                                                   │
│   unhealthyPodEvictionPolicy: AlwaysAllow
k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)~~ [ConnorJC3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment