search

kubernetes-sigs / aws-efs-csi-driver

CSI Driver for Amazon EFS https://aws.amazon.com/efs/
Apache License 2.0
693 stars 526 forks source link

Pre-release PRs for v2.0.0 #1312

Closed mskanth972 closed 2 months ago

mskanth972 commented 2 months ago

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it? Pre-release PRs for v2.0.0 for master branch

What testing is done?

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mskanth972, seanzatzdev-amazon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/OWNERS)~~ [mskanth972,seanzatzdev-amazon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
willhughes-au commented 2 months ago

This PR and the ones related to it indicate v2.0.0, but the changelog doesn't indicate why the major version is being incremented.

Is there a breaking change? If so, what?

mskanth972 commented 2 months ago

Hi @willhughes-au, here is the changelog which indicates the new release happened in efs-utils, a major change which is replacing Stunnel by default with an new built-in AWS component efs-proxy for TLS encryptions mounts.

willhughes-au commented 2 months ago

Thanks for the quick reply.

So just changing to efs-utils causes the major version change - but it's safe to assume that there's no breaking changes from a consumer perspective?

mskanth972 commented 2 months ago

EFS CSI Driver uses efs-utils as an mount helper, so whatever changes are being made to efs utils they will be throughly tested from EFS CSI Diver/consumer perspective.