Typo in Helm chart values file podLabel should be podLabels

[ismaillatona]

/kind bug

What happened? Pod labels are not set on the controller pods. While looking at the default values file there is a typo at controller.podLabel it should be controller.podLabels as referenced in the templates What you expected to happen? I expected pod labels to be set on the controller pods How to reproduce it (as minimally and precisely as possible)? Setting podLabel value does not set the controller pod labels Anything else we need to know?:

Environment

• Kubernetes version (use kubectl version):
• Driver version:

Please also attach debug logs to help us better diagnose

• Instructions to gather debug logs can be found here

[r-yabyab]

/assign

[r-yabyab]

The chart value's controller.podLabel works for me. Couldn't get controller.podLabels to work.

[chris-bosman]

A few more details:

In values.yaml, here, the name of the variable is PodLabel.

But it does not appear as though this will ever modify the tags on the deployed pods, since the code for the pod's labels here references a variable called PodLabels.

The two files need to be reconciled to agree on the variable name. The simplest would simply be renaming controller.PodLabel to controller.PodLabels to agree with what's currently in the controller deployment definition.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale