kubernetes-sigs / aws-efs-csi-driver

CSI Driver for Amazon EFS https://aws.amazon.com/efs/
Apache License 2.0
711 stars 545 forks source link

Tags configurations dynamically provisioning #1351

Open omerap12 opened 4 months ago

omerap12 commented 4 months ago

Is this a bug fix or adding new feature? Add Tags Configurations In dynamically Provisioning Access Points. Added tests

What is this PR about? / Why do we need it?

1346

What testing is done? Manually tested by using the following manifest:

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: efs-sc
provisioner: efs.csi.aws.com
parameters:
  provisioningMode: efs-ap
  fileSystemId: fs-0d4bbee0eb9759244
  directoryPerms: "700"
  pvcTags: "service_name=my_service,team=infra,environment=development"
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: efs-claim
spec:
  accessModes:
    - ReadWriteMany
  storageClassName: efs-sc
  volumeMode: Filesystem
  resources:
    requests:
      storage: 20Gi

---
apiVersion: v1
kind: Pod
metadata:
  name: efs-example
spec:
  containers:
    - name: app
      image: centos
      command: ["/bin/sh"]
      args: ["-c", "while true; do echo $(date -u) >> /example/out.txt; sleep 5; done"]
      volumeMounts:
        - name: persistent-storage
          mountPath: /example
  volumes:
    - name: persistent-storage
      persistentVolumeClaim:
        claimName: efs-claim

Which created the following tags: image

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12 Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
omerap12 commented 4 months ago

Hey, can you please review? @Ashley-wenyizha @mskanth972

genural commented 4 months ago

Hey, any update?

k8s-ci-robot commented 1 month ago

@omerap12: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-efs-csi-driver-unit 49f2f1aaf3e7ab7f46a9a05113406de97c8c113c link true /test pull-aws-efs-csi-driver-unit
pull-aws-efs-csi-driver-verify 49f2f1aaf3e7ab7f46a9a05113406de97c8c113c link true /test pull-aws-efs-csi-driver-verify
pull-aws-efs-csi-driver-external-test-eks 49f2f1aaf3e7ab7f46a9a05113406de97c8c113c link true /test pull-aws-efs-csi-driver-external-test-eks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
aymen-cherif commented 2 weeks ago

Any updates please?