kubernetes-sigs / aws-efs-csi-driver

CSI Driver for Amazon EFS https://aws.amazon.com/efs/
Apache License 2.0
711 stars 545 forks source link

Spaces/colons in access point tags #1374

Open Deepercreeper opened 3 months ago

Deepercreeper commented 3 months ago

/kind bug

What happened? The aws-efs-csi-driver controller fails to parse given tags for access points logging: E0613 13:04:49.293878 1 driver.go:144] Failed to parse input tag string: Key with spaces:value

What you expected to happen? Since spaces are supported by the AWS tagging API (including EFS) tags with spaces should be supported by the aws-efs-csi-driver controller as well.

How to reproduce it (as minimally and precisely as possible)? Deploy the aws-efs-csi-driver helm chart passing the following values:

controller:
  tags:
    key with spaces: value

Anything else we need to know?: This goes for keys and values of tags. The same goes for the colon (:) as part of tag values as it is used to separate key and value when passing the command line argument to the controller pod.

Environment

Please also attach debug logs to help us better diagnose aws-efs-csi-driver.txt

k8s-triage-robot commented 2 weeks ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale