search

kubernetes-sigs / aws-efs-csi-driver

CSI Driver for Amazon EFS https://aws.amazon.com/efs/
Apache License 2.0
711 stars 545 forks source link

Add `metadata.namespace` to chart templates #1376

Open Kellen275 opened 3 months ago

Kellen275 commented 3 months ago

This MR aligns with practices followed by the aws-ebs-csi-driver chart.

This also improves compatibility with ArgoCD, which otherwise will complain when it detects no namespace field for namespaced k8s resources. See screenshot below

Screenshot from 2024-06-17 08-37-02

linux-foundation-easycla[bot] commented 3 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 3 months ago

Welcome @Kellen275!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 months ago

Hi @Kellen275. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Kellen275 commented 3 months ago

Not quite sure why the EasyCLA is marked as "Not Covered" still. Received a confirmation email and all looks good?

Screenshot from 2024-06-17 08-43-11

dims commented 3 months ago

/easycla

dims commented 3 months ago

@Kellen275 the commits show From: Kellen Sappington <kellen.sappington@ga-ccri.com> as your email, if you match that with the email id you used for CLA that would make it work. You can also try associating this email with your github as an additional email as an alternative.

PS: https://github.com/kubernetes-sigs/aws-efs-csi-driver/commit/fa33fad37ffd42b009b3e33a3e0bb4c9a2c9b357.patch

Kellen275 commented 3 months ago

Thanks @dims , looks like that was it :slightly_smiling_face:

Kellen275 commented 1 month ago

Hello @dims , is there anything remaining for this PR?

dims commented 1 week ago

/ok-to-test

/assign @mskanth972 @arnavgup1

k8s-ci-robot commented 1 week ago

@dims: GitHub didn't allow me to assign the following users: arnavgup1.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/aws-efs-csi-driver/pull/1376#issuecomment-2364951559): >/ok-to-test > >/assign @mskanth972 @arnavgup1 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kellen275 Once this PR has been reviewed and has the lgtm label, please ask for approval from mskanth972. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment