search

kubernetes-sigs / aws-efs-csi-driver

CSI Driver for Amazon EFS https://aws.amazon.com/efs/
Apache License 2.0
723 stars 554 forks source link

Add Pod Identity documentation in README #1381

Closed arnavgup1 closed 5 months ago

arnavgup1 commented 5 months ago

Is this a bug fix or adding new feature? Feature

What is this PR about? / Why do we need it? Adds documentation for the Pod Identity feature used for customers that want to authenticate with the pod identity agent that is available through EKS Add-ons.

PR for the pod identity change: https://github.com/kubernetes-sigs/aws-efs-csi-driver/pull/1254

k8s-ci-robot commented 5 months ago

Hi @arnavgup1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
seanzatzdev-amazon commented 5 months ago

/lgtm

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arnavgup1, seanzatzdev-amazon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/OWNERS)~~ [seanzatzdev-amazon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
seanzatzdev-amazon commented 5 months ago

/ok-to-test

kkopachev commented 4 months ago

I have a question about the language added by this PR. It seems that adding AmazonEFSCSIDriverPolicy policy to the cluster's node group's IAM role is essentially the same as third method using instance profile policy: If my node has AmazonEFSCSIDriverPolicy on it, then any pod on that node can use it, regardless of EKS Pod Identity presence. Am I missing something here?

leondkr commented 3 months ago

Hi @kkopachev

You can check my PR#1422 here for further explanation of using EKS Pod Identities feature with EFS CSI.

Basically, it is only required to be added with the IAM role associated with EFS CSI controller.