kubernetes-sigs / aws-efs-csi-driver

CSI Driver for Amazon EFS https://aws.amazon.com/efs/
Apache License 2.0
723 stars 554 forks source link

Fix controller.podLabels typo in values.yaml #1445

Closed pvickery-ParamountCommerce closed 1 week ago

pvickery-ParamountCommerce commented 2 months ago

Is this a bug fix or adding new feature? This fixes a typo in values.yaml which can cause confusion. controller.podLabel -> controller.podLabels

What is this PR about? / Why do we need it?

What testing is done? Searching for the use of .Values.controller.podLabel https://github.com/search?q=repo%3Akubernetes-sigs%2Faws-efs-csi-driver%20controller.podLabels&type=code

k8s-ci-robot commented 2 months ago

Welcome @pvickery-ParamountCommerce!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 months ago

Hi @pvickery-ParamountCommerce. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
pvickery-ParamountCommerce commented 1 month ago

@mskanth972 Would you be able to review this super small PR?

mskanth972 commented 1 month ago

Looks good to me, can you squash the commits so that I can merge?

pvickery-ParamountCommerce commented 1 month ago

Great thanks! I've finished the rebase

@mskanth972 in case you didn't get a notification

mskanth972 commented 1 month ago

/ok-to-test /lgtm

pvickery-ParamountCommerce commented 4 weeks ago

@mskanth972 The tests have completed, can you approve to add the label?

pvickery-ParamountCommerce commented 1 week ago

@mskanth972 can we get this merged?

mskanth972 commented 1 week ago

/ok-to-test

mskanth972 commented 1 week ago

@mskanth972 can we get this merged?

Sure, will merge once the above tests are done.

pvickery-ParamountCommerce commented 1 week ago

/test pull-aws-efs-csi-driver-unit

pvickery-ParamountCommerce commented 1 week ago

I noticed there is another PR for this change @bart-braidwell https://github.com/kubernetes-sigs/aws-efs-csi-driver/pull/1442

pvickery-ParamountCommerce commented 1 week ago

@mskanth972 tests have now passed. The pull-aws-efs-csi-driver-unit strangely failed but passed when I ran it again so I think the test is flaky.

mskanth972 commented 1 week ago

/lgtm /approve

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mskanth972, pvickery-ParamountCommerce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/OWNERS)~~ [mskanth972] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment