Closed pvickery-ParamountCommerce closed 1 week ago
Welcome @pvickery-ParamountCommerce!
It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @pvickery-ParamountCommerce. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@mskanth972 Would you be able to review this super small PR?
Looks good to me, can you squash the commits so that I can merge?
Great thanks! I've finished the rebase
@mskanth972 in case you didn't get a notification
/ok-to-test /lgtm
@mskanth972 The tests have completed, can you approve to add the label?
@mskanth972 can we get this merged?
/ok-to-test
@mskanth972 can we get this merged?
Sure, will merge once the above tests are done.
/test pull-aws-efs-csi-driver-unit
I noticed there is another PR for this change @bart-braidwell https://github.com/kubernetes-sigs/aws-efs-csi-driver/pull/1442
@mskanth972 tests have now passed. The pull-aws-efs-csi-driver-unit
strangely failed but passed when I ran it again so I think the test is flaky.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mskanth972, pvickery-ParamountCommerce
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Is this a bug fix or adding new feature? This fixes a typo in values.yaml which can cause confusion.
controller.podLabel
->controller.podLabels
What is this PR about? / Why do we need it?
What testing is done? Searching for the use of
.Values.controller.podLabel
https://github.com/search?q=repo%3Akubernetes-sigs%2Faws-efs-csi-driver%20controller.podLabels&type=code