search

kubernetes-sigs / aws-encryption-provider

APIServer encryption provider, backed by AWS KMS
Apache License 2.0
210 stars 76 forks source link

Delete vendor directory #87

Closed jngo2 closed 1 year ago

jngo2 commented 2 years ago

Removing the vendor directory as requested.

k8s-ci-robot commented 2 years ago

Hi @jngo2. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
micahhausler commented 2 years ago

/retest

micahhausler commented 2 years ago

@jngo2 I think you'll have to fix some of the test expectations about vendored code

jngo2 commented 2 years ago

/retest

k8s-ci-robot commented 2 years ago

@jngo2: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubernetes-sigs/aws-encryption-provider/pull/87#issuecomment-1268770245): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
micahhausler commented 1 year ago

/retest

xdu31 commented 1 year ago

/retest

k8s-ci-robot commented 1 year ago

@xdu31: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubernetes-sigs/aws-encryption-provider/pull/87#issuecomment-1337660263): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xdu31 commented 1 year ago

@jngo2 Need to change on lint target in makefile top resolve pull-aws-encryption-provider-verify: https://github.com/kubernetes-sigs/aws-encryption-provider/blob/master/Makefile#L10-L11 as part of the prow job definition in https://github.com/kubernetes/test-infra/blob/f7e21a3c18f4f4bbc7ee170675ed53e4544a[…]ig/jobs/kubernetes-sigs/aws-encryption-provider/presubmits.yaml

micahhausler commented 1 year ago

/ok-to-test

micahhausler commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jngo2, micahhausler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-encryption-provider/blob/master/OWNERS)~~ [micahhausler] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment