kubernetes-sigs / aws-iam-authenticator

A tool to use AWS IAM credentials to authenticate to a Kubernetes cluster
Apache License 2.0
2.21k stars 423 forks source link

github release v0.5.2 does not include executable assets #344

Closed dsayling closed 4 years ago

dsayling commented 4 years ago

v0.5.1 (and previous releases) contained the executables assets in the release for ease of downloading

e.g. in 0.5.1

image

This causes any automation that's depending on the github release to contain the assets to fail.

si-mmarcoux commented 4 years ago

+1 on this! Urgent matter blocking our production pipelines!

allenwei commented 4 years ago

+1

dileepfrog commented 4 years ago

+1

lu911 commented 4 years ago

+1

QUSHLEE commented 4 years ago

+1

JaehunYoon commented 4 years ago

+1

wiamsuri commented 4 years ago

A quick solution would be to freeze version to v0.5.1 For those of you (like me) who came here from CircleCI aws-eks orbs, you can freeze the version by adding.

- aws-eks/update-kubeconfig-with-authenticator:
    authenticator-release-tag: v0.5.1
    cluster-name: my-eks-cluster
jbauerrfid commented 4 years ago

Found the same issue this morning. This causes the CircleCI aws-eks orb to fail on command aws-eks/update-kubeconfig-with-authenticator unless you specify an older release tag. -> https://circleci.com/developer/orbs/orb/circleci/aws-eks#commands-update-kubeconfig-with-authenticator The error output is like:

DOWNLOAD_URL="https://github.com/kubernetes-sigs/aws-iam-authenticator/releases/download/${VERSION}/${FILENAME}_${VERSION_NUMBER}_${PLATFORM}_amd64"

curl -L --fail --retry 3 -o aws-iam-authenticator "$DOWNLOAD_URL"

chmod +x ./aws-iam-authenticator

SUDO=""
if [ $(id -u) -ne 0 ] && which sudo > /dev/null ; then
  SUDO="sudo"
fi

$SUDO mv ./aws-iam-authenticator /usr/local/bin/aws-iam-authenticator
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found

Exited with code exit status 22
CircleCI received exit code 22
jbauerrfid commented 4 years ago

Hardcoding the version is a valid solution, but I would rather put the version string into the CI environment and reference it in the orb configuration. Otherwise moving to a new versions means to update every repo using it.

parkerjm commented 4 years ago

A quick solution would be to freeze version to v0.5.1 For those of you (like me) who came here from CircleCI aws-eks orbs, you can freeze the version by adding.

- aws-eks/update-kubeconfig-with-authenticator:
    authenticator-release-tag: v0.5.1
    cluster-name: my-eks-cluster

unfortunately, if you use update-container-image, there appears to be no way to version-lock the aws-iam-authenticator currently: https://circleci.com/developer/orbs/orb/circleci/aws-eks#jobs-update-container-image

jbauerrfid commented 4 years ago

with the latest fix from @lokst you can also update the orb:

orbs:
  aws-eks: circleci/aws-eks@1.0.1

just tested it, this has the same effect

nckturner commented 4 years ago

I republished the release with the executables.

/close

k8s-ci-robot commented 4 years ago

@nckturner: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/aws-iam-authenticator/issues/344#issuecomment-705069616): >I republished the release with the executables. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.