search

kubernetes-sigs / aws-iam-authenticator

A tool to use AWS IAM credentials to authenticate to a Kubernetes cluster
Apache License 2.0
2.2k stars 421 forks source link

fix arn comparison for IAM ARN #674

Closed nnmin-aws closed 9 months ago

nnmin-aws commented 9 months ago

What this PR does / why we need it: this PR fix the issue in PR 669. The original fix doesn't work.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

nnmin-aws commented 9 months ago

/ok-to-test

nckturner commented 9 months ago

/lgtm /approve

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, nnmin-aws

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-iam-authenticator/blob/master/OWNERS)~~ [nckturner] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nnmin-aws commented 9 months ago

/merge

nnmin-aws commented 9 months ago

/retest