search

kubernetes-sigs / aws-iam-authenticator

A tool to use AWS IAM credentials to authenticate to a Kubernetes cluster
Apache License 2.0
2.17k stars 416 forks source link

chore: Update `k8s.io` libraries #684

Closed bryantbiggs closed 6 months ago

bryantbiggs commented 6 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Resolves #627 Resolves #638

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bryantbiggs Once this PR has been reviewed and has the lgtm label, please assign micahhausler for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/aws-iam-authenticator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 6 months ago

Hi @bryantbiggs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
nnmin-aws commented 6 months ago

/ok-to-test

nnmin-aws commented 6 months ago

/retest

bryantbiggs commented 6 months ago

hmm, that doesn't look good. let me dig in a bit more

k8s-ci-robot commented 6 months ago

@bryantbiggs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-iam-authenticator-unit c2af1edf81a3951c4af34a7d5f31fae3e9b16fcd link true /test pull-aws-iam-authenticator-unit
pull-aws-iam-authenticator-e2e-kind c2af1edf81a3951c4af34a7d5f31fae3e9b16fcd link true /test pull-aws-iam-authenticator-e2e-kind
pull-aws-iam-authenticator-integration c2af1edf81a3951c4af34a7d5f31fae3e9b16fcd link true /test pull-aws-iam-authenticator-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
bryantbiggs commented 6 months ago

closing in favor of #687 - will follow up with a 2nd PR later for the context object propagation changes