search

kubernetes-sigs / aws-iam-authenticator

A tool to use AWS IAM credentials to authenticate to a Kubernetes cluster
Apache License 2.0
2.17k stars 416 forks source link

chore: Update CLI dependencies `cobra` and `viper` #689

Closed bryantbiggs closed 2 months ago

bryantbiggs commented 5 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

k8s-ci-robot commented 5 months ago

Hi @bryantbiggs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
nnmin-aws commented 5 months ago

/ok-to-test

nnmin-aws commented 5 months ago

/lgtm

bryantbiggs commented 5 months ago

/retest

nnmin-aws commented 5 months ago

/lgtm

bryantbiggs commented 3 months ago

/retest

bryantbiggs commented 3 months ago

/retest-required

wongma7 commented 2 months ago

/lgtm /approve

will need rebase on https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/687 and https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/706

bryantbiggs commented 2 months ago

/retest

bryantbiggs commented 2 months ago

cc @wongma7

wongma7 commented 2 months ago

/lgtm /approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryantbiggs, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-iam-authenticator/blob/master/OWNERS)~~ [wongma7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wongma7 commented 2 months ago

An error occurred (NoSuchEntity) when calling the DeleteRole operation: The role with name aws-iam-authenticator-test-role-KubernetesAdmin cannot be found.

seems the role name gets reused and tests race each other.

bryantbiggs commented 2 months ago

/retest

wongma7 commented 2 months ago

/lgtm