search

kubernetes-sigs / aws-iam-authenticator

A tool to use AWS IAM credentials to authenticate to a Kubernetes cluster
Apache License 2.0
2.2k stars 421 forks source link

Release 0.6 #712

Closed jaidevmane closed 5 months ago

jaidevmane commented 5 months ago

What this PR does / why we need it: Cherry picking commits to release new version of authenticator on the release-0.6 branch.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

k8s-ci-robot commented 5 months ago

Hi @jaidevmane. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaidevmane Once this PR has been reviewed and has the lgtm label, please assign jaypipes for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/aws-iam-authenticator/blob/release-0.6/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jaidevmane commented 5 months ago

/ok-to-test

k8s-ci-robot commented 5 months ago

@jaidevmane: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/712#issuecomment-2076063433): >/ok-to-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
wongma7 commented 5 months ago

/ok-to-test

bryantbiggs commented 5 months ago

I think there are more commits required - #687 has a diff of +767/−1,466 alone

k8s-ci-robot commented 5 months ago

@jaidevmane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-iam-authenticator-unit 86119bb7d3ac9d915e23ca871d1e3a1755c91f7c link true /test pull-aws-iam-authenticator-unit
pull-aws-iam-authenticator-e2e-kind 86119bb7d3ac9d915e23ca871d1e3a1755c91f7c link true /test pull-aws-iam-authenticator-e2e-kind
pull-aws-iam-authenticator-e2e 86119bb7d3ac9d915e23ca871d1e3a1755c91f7c link true /test pull-aws-iam-authenticator-e2e
pull-aws-iam-authenticator-integration 86119bb7d3ac9d915e23ca871d1e3a1755c91f7c link true /test pull-aws-iam-authenticator-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).