chore: Update e2e and integration test Kubernetes/kOps versions

kubernetes-sigs / aws-iam-authenticator

A tool to use AWS IAM credentials to authenticate to a Kubernetes cluster

Apache License 2.0

2.2k stars 421 forks source link

chore: Update e2e and integration test Kubernetes/kOps versions #716

Open bryantbiggs opened 5 months ago

bryantbiggs commented 5 months ago

What this PR does / why we need it:

Update e2e and integration test Kubernetes/kOps versions - these look like they haven't been updated for a few years so bumping to the latest (latest K8s version supported in EKS)
Replace makefile with script to update codegen
- The makefile driven code generation was removed in upstream in 1.25 and replaced with a script https://github.com/kubernetes/kubernetes/pull/112819

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

bryantbiggs commented 5 months ago

will need to spend a bit more time to look into this, converting to draft for now

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bryantbiggs Once this PR has been reviewed and has the lgtm label, please assign wongma7 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/aws-iam-authenticator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

bryantbiggs commented 5 months ago

somewhere, we are using an older version of the authenticator in the e2e test but I can't spot where in the code. From the e2e test output:

W0429 11:46:49.577654 6344 builder.go:232] failed to digest image "602401143452.dkr.ecr.us-west-2.amazonaws.com/amazon/aws-iam-authenticator:v0.5.12": GET https://602401143452.dkr.ecr.us-west-2.amazonaws.com/v2/amazon/aws-iam-authenticator/manifests/v0.5.12: unexpected status code 401 Unauthorized: Not Authorized

k8s-ci-robot commented 5 months ago

@bryantbiggs: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-aws-iam-authenticator-e2e	759d2f23502f5627622e9ffcf941221215ddef8f	link	true	`/test pull-aws-iam-authenticator-e2e`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

bryantbiggs commented 3 months ago

commit https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/716/commits/a08d60d4844beb54adf5e3e20bc338349178772d corrects changes made in https://github.com/kubernetes-sigs/aws-iam-authenticator/commit/cc68d2315305ba17452a5a4f1868db14b77a0090

k8s-ci-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.