search

kubernetes-sigs / aws-load-balancer-controller

A Kubernetes controller for Elastic Load Balancers
https://kubernetes-sigs.github.io/aws-load-balancer-controller/
Apache License 2.0
3.93k stars 1.46k forks source link

[V2] wafv2 not working #1496

Closed matt-demers closed 4 years ago

matt-demers commented 4 years ago

I created an ingress object with the annotation set alb.ingress.kubernetes.io/wafv2-acl-arn: "arn:aws:wafv2:us-east-1:<account>:regional/webacl/<stuff>". But I do not see the waf being associated with the load balancer. I think I traced it down to this line https://github.com/kubernetes-sigs/aws-alb-ingress-controller/blob/v2_ga/pkg/config/addons_config.go#L25

I think this was meant to be fs.BoolVar(&f.WAFV2Enabled, flagWAFV2Enabled, defaultEnabled, "Enable WAF V2 addon for ALB")

kishorj commented 4 years ago

Thanks. I will update the default values.

M00nF1sh commented 4 years ago

closing this as v2.0.0-rc4 addressed it :D