search

kubernetes-sigs / aws-load-balancer-controller

A Kubernetes controller for Elastic Load Balancers
https://kubernetes-sigs.github.io/aws-load-balancer-controller/
Apache License 2.0
3.93k stars 1.46k forks source link

Allow default set of AWS Tags to be specified on the controller #187

Closed matt-deboer closed 5 years ago

matt-deboer commented 7 years ago

[enhancement] It would be convenient if I could specify a default set of Tags on the controller, such that all ALBs it creates would be given those tags (some of which might be overridden by an individual Ingress object's annotations).

joshrosso commented 7 years ago

Yeah, I like this a lot. Good way for companies to standardize. I'm going to mark this as 1.1 but I could see it making 1.0.

d-shi commented 7 years ago

+1. We run multiple k8s clusters, and it would be nice to be able to specify tags to keep track of costs per cluster.

hugohenley commented 6 years ago

up

michaelajr commented 1 month ago

Was this implemented as an override to the annotation on the Ingress? Because that is the behavior we are seeing. If my Ingress has the tags annotation - then I would think they would take precedence over default tags that controller would use. So a union of the default tags and tags in the ingress annotation, where the tags specified on the ingress annotation take precedence if there is collision - is what I would expect. Otherwise you have tag overrides - not default tags.