search

kubernetes-sigs / aws-load-balancer-controller

A Kubernetes controller for Elastic Load Balancers
https://kubernetes-sigs.github.io/aws-load-balancer-controller/
Apache License 2.0
3.95k stars 1.47k forks source link

ingressClass vs Annotations kubernetes.io/ingress.class #2097

Closed runningman84 closed 3 years ago

runningman84 commented 3 years ago

Describe the bug Right now you cannot deploy a resource with ingressClass set to alb and annotation kubernetes.io/ingress.class set to alb at the same time.

Other ingress controllers like treafik do not complain here.

Steps to reproduce deploy a resource with ingressClass set to alb and annotation kubernetes.io/ingress.class set to alb at the same time

Expected outcome Just print a warning that annotation kubernetes.io/ingress.class is deprecated.

Environment

Additional Context:

M00nF1sh commented 3 years ago

@runningman84 The validation is enforced by Kubernetes instead of our controller: https://github.com/kubernetes/kubernetes/blob/v1.19.0/pkg/apis/networking/validation/validation.go#L228

I don't think treafik will work with this case as well on 1.19 😃

runningman84 commented 3 years ago

ok yes I have also seen errors in our traefik deployment now....