Closed edr-devops closed 1 year ago
Hi, we changed the default value of ingress class from "" to "alb" because we'd encourage the usage of IngressClass and deprecate kubernetes.io/ingress.class
annotation via flag--disable-ingress-class-annotation
, which requires a non-empty ingress class setting.
Any specific reason why you don't want to use spec.ingressClassName ?
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
@edr-devops, I'm closing this issue as for now, please feel free to reach out or reopen if you have any questions. Thanks.
Describe the bug According to the documentation, if ingress-glass argument is left empty, the controller should take action on any ingress defined on the cluster, however i am not seeing that behaviour.
I believe it is because since 2.2.0 the default ingressClass is set as 'alb'. https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/pkg/config/ingress_config.go#L10
I maybe misunderstanding the logic but passing --ingress-class="", or not passing the --ingress-class argument seems to still require that spec.ingressClassName: alb is still required on ingresses.
Prior to 1.2.0, the ingress controller successfully creates targetGroupBindings for those ingresses without the .spec.ingressClassName. (or ingress-class annotation). The code for 2.1.3, has a default value of "" - https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/v2.1.3/pkg/config/ingress_config.go#L8.
I maybe doing something wrong, so apologies in advance if that is the case.
Steps to reproduce Deploy controller with no --ingress-class specified, and create an ingress within spec.ingressClassName (or deprecated annotation).
Expected outcome With no ingress-class specified, the controller should try to create targetGroupBindings for ingresses without a .spec.ingresClassName defined.
Environment AWS EKS 1.20+