search

kubernetes-sigs / aws-load-balancer-controller

A Kubernetes controller for Elastic Load Balancers
https://kubernetes-sigs.github.io/aws-load-balancer-controller/
Apache License 2.0
3.96k stars 1.47k forks source link

Log message for conflicting SSL policy lists the same ingress name twice #3125

Closed jbg closed 9 months ago

jbg commented 1 year ago

Describe the bug When two ingresses in the same group have conflicting SSL policies, the log message lists the same ingress twice, making it more difficult to determine the source of the conflict.

Steps to reproduce Create two ingresses, first-ingress and second-ingress sharing the same group but with different SSL policies.

The resulting error looks like:

{"level":"error","ts":1679760043.6535313,"logger":"controller.ingress","msg":"Reconciler error","name":"ingress-group-name","namespace":"","error":"failed to merge listenPort config for port: 443: conflicting sslPolicy, default/first-ingress: ELBSecurityPolicy-TLS-1-2-2017-01 | default/first-ingress: ELBSecurityPolicy-TLS13-1-2-2021-06"}

Note that first-ingress is referenced alongside both SSL policies.

Expected outcome An error listing the two different ingress names which have the conflicting SSL policies.

Environment

Additional Context:

The errant code is presumably here.

kishorj commented 1 year ago

/kind bug

@jbg, thanks for reporting, we will investigate further and fix.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 10 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 9 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 9 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/aws-load-balancer-controller/issues/3125#issuecomment-1950971718): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.