kubernetes-sigs / aws-load-balancer-controller

A Kubernetes controller for Elastic Load Balancers
https://kubernetes-sigs.github.io/aws-load-balancer-controller/
Apache License 2.0
3.82k stars 1.41k forks source link

exclude some namespace from mutatingwebhookadmission interception #3599

Open zoezhangmattr opened 4 months ago

zoezhangmattr commented 4 months ago

Is your feature request related to a problem? A description of what the problem is. For example: I'm frustrated when [...] by using the helm chart the mutatingwebhookadmission has rules for create service which doesnt allow exclusion configuration, such as, exclude kube-system namespace. so that event alb mutatingwebhookadmission is not working properly, it wont impact resources in kube-system.

unless there is another way to prevent the impact? happy take advices. Describe the solution you'd like A description of what you want to happen.

Describe alternatives you've considered A description of any alternative solutions or features you've considered.

oliviassss commented 3 months ago

@zoezhangmattr, currently the namespace is the same with the helm chart release namespace. you mean you install the load balancer controller in kube-system, but do not want the webhook service to be created in kube-system? just for my understanding, how would the failure in LBC mutatingwebhookadmission affect other resources in the namespace? it should be scope down to specific resources only, right?

zoezhangmattr commented 3 months ago

@zoezhangmattr, currently the namespace is the same with the helm chart release namespace. you mean you install the load balancer controller in kube-system, but do not want the webhook service to be created in kube-system? just for my understanding, how would the failure in LBC mutatingwebhookadmission affect other resources in the namespace? it should be scope down to specific resources only, right?

hi, thanks for your reply

i installed the controller in non kube-system namespace, e.g. alb-controller namespace

the webhook without further configuration will be called, whenever a service is updated, for example, install an nginx release and expose the service, . that means, if alb controller is down, for example, cabundle is not correct, during the alb controller downtime, nginx service is not gonna installed, because the webhook is called,

k8s-triage-robot commented 1 day ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale