search

kubernetes-sigs / aws-load-balancer-controller

A Kubernetes controller for Elastic Load Balancers
https://kubernetes-sigs.github.io/aws-load-balancer-controller/
Apache License 2.0
3.82k stars 1.41k forks source link

[Feature Request] Add Ingress/Service object annotations to support recently added HTTP client keepalive duration #3670

Closed kswift closed 1 month ago

kswift commented 2 months ago

Is your feature request related to a problem? Elastic Load Balancing team recently released HTTP client keepalive duration which can be configured for ALBs -> https://aws.amazon.com/about-aws/whats-new/2024/03/application-load-balancer-http-keepalive-duration/

This keepalive value specifies the maximum amount of time that ALB will maintain an HTTP connection with a client before closing the connection.

Describe the solution you'd like Specify this duration value via Ingress/Service object annotations.

Describe alternatives you've considered Configuring manually via awscli or console in meantime.

shraddhabang commented 2 months ago

/assign ChuksGrinage

k8s-ci-robot commented 2 months ago

@shraddhabang: GitHub didn't allow me to assign the following users: ChuksGrinage.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/aws-load-balancer-controller/issues/3670#issuecomment-2087645388): >/assign ChuksGrinage Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
omerap12 commented 1 month ago

Hey @shraddhabang , are you sure that's documentation issue?

omerap12 commented 1 month ago

/assign

ChuksGrinage commented 1 month ago

From what I understand, annotations are just a key/value pairing of the options available to the ALB. And seeing that KAT is a fairly recent addition we can see how our annotation list would be out of date.

ChuksGrinage commented 1 month ago

We can confirm that you can set client keepalive time (KAT) by simply including annotation: For example: alb.ingress.kubernetes.io/load-balancer-attributes: client_keep_alive.seconds=3600

We are working to update the docs for future references

omerap12 commented 1 month ago

@ChuksGrinage so nothing is needed for me then?

ChuksGrinage commented 1 month ago

@omerap12 Yes, no action is needed. Thank you!

ChuksGrinage commented 1 month ago

/assign