Upgrade Kubernetes libs to v0.29.x.

jlrgraham commented 2 months ago

Issue

https://github.com/kubernetes-sigs/aws-load-balancer-controller/issues/3649

Description

Bumped the versions of all the k8s.io libraries to their latest v0.29.x versions:

grep k8s.io go.mod | grep -v indirect | awk '/0.26/ {print $1}' | xargs -I{} go get {}@v0.29

Checklist

[-] Added tests that cover your change (if possible)
[-] Added/modified documentation as required (such as the README.md, or the docs directory)
[x] Manually tested (passed make unit-test)
[x] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

[ ] Backfilled missing tests for code in same general area :tada:
[ ] Refactored something and made the world a better place :star2:

linux-foundation-easycla[bot] commented 2 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: jlrgraham / name: Justin Graham (496f6865109f0cc095e00ae99a2dbd1f7d704c75, da94a74f7d9ea070be21b59f4f5503adf65dfd28)

k8s-ci-robot commented 2 months ago

Welcome @jlrgraham!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 months ago

Hi @jlrgraham. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jlrgraham Once this PR has been reviewed and has the lgtm label, please assign m00nf1sh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

connerstobie commented 1 month ago

Bump, please review!

aaroniscode commented 1 month ago

/ok-to-test

aaroniscode commented 1 month ago

@jlrgraham there are some inconsistencies with your go modules ... I checked out your branch and couldn't build the project.

Consider running go mod tidy. Though I ran that and still couldn't build the project as there were some missing methods. I recommend using a clean build machine and checking out your PR so you can verify the issues and fix.

aaroniscode commented 1 month ago

@jlrgraham found what I think is at least part of the issue. controller-runtime needs to be upgraded to at least v0.15.0.

https://github.com/kubernetes-sigs/controller-runtime/pull/2223 adds support to controller-runtime for with client-go 1.27 and higher.

Note there are significant breaking changes when upgrading controller-runtime to v0.15.0 so this is looking a lot more complicated as I still can't get the project to build and I believe I'm hitting these breaking changes.

k8s-ci-robot commented 1 month ago

@jlrgraham: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-aws-load-balancer-controller-unit-test	da94a74f7d9ea070be21b59f4f5503adf65dfd28	link	true	`/test pull-aws-load-balancer-controller-unit-test`
pull-aws-load-balancer-controller-e2e-test	da94a74f7d9ea070be21b59f4f5503adf65dfd28	link	true	`/test pull-aws-load-balancer-controller-e2e-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

oliviassss commented 1 month ago

@aaroniscode, yes we plan to upgrade the controller-runtime to v0.15+, but it has breaking changes and may need more time and efforts to investigate and implement corresponding changes. I think we need to do it sooner than later. Any community contribution is very welcome. Thanks.

k8s-ci-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

kubernetes-sigs / aws-load-balancer-controller