Add non-alphanumeric input validation test for vpcID and fix typo

kubernetes-sigs / aws-load-balancer-controller

A Kubernetes controller for Elastic Load Balancers

https://kubernetes-sigs.github.io/aws-load-balancer-controller/

Apache License 2.0

3.82k stars 1.41k forks source link

Add non-alphanumeric input validation test for vpcID and fix typo #3687

Closed shraddhabang closed 1 month ago

shraddhabang commented 1 month ago

Issue

N/A

Description

As per the request from security team, adding a unit test for malicious input validation for vpcid
Also fixed the typo for certificate arn in IngressClassParam CRD
Added more docs around the Cert arn support for IngressClassParam CRD.
Ran E2E tests locally and verified the change

Checklist

[x] Added tests that cover your change (if possible)
[x] Added/modified documentation as required (such as the README.md, or the docs directory)
[x] Manually tested
[x] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

[ ] Backfilled missing tests for code in same general area :tada:
[ ] Refactored something and made the world a better place :star2:

wweiwei-li commented 1 month ago

/lgtm

k8s-ci-robot commented 1 month ago

@wweiwei-li: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/aws-load-balancer-controller/pull/3687#issuecomment-2103471260): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

oliviassss commented 1 month ago

/lgtm /approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliviassss, shraddhabang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/OWNERS)~~ [oliviassss] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment