kubernetes-sigs / aws-load-balancer-controller

A Kubernetes controller for Elastic Load Balancers
https://kubernetes-sigs.github.io/aws-load-balancer-controller/
Apache License 2.0
3.82k stars 1.41k forks source link

[Doc] Worker node security groups selection #3705

Closed yyyoungha closed 4 weeks ago

yyyoungha commented 1 month ago

Is your feature request related to a problem? Worker node security groups selection is only mentioned under the /docs/guide/service/ path. However, I have found through testing that this works the same in Ingress.

The path to which this document is located may lead one to misunderstand that this only applies to Services and not Ingress.

Describe the solution you'd like Worker node security groups selection is the same in Ingress, so this content should also be included in the Ingress guide.

Describe alternatives you've considered Since it applies to both Ingress and Service, it would also be a good to create a separate folder under the /docs/guide path and explain how LBC detects security groups and add rules.

oliviassss commented 1 month ago

@yyyoungha, we originally have this doc in service side, because they are for backend service. I think it's the same case for ingress because of the backend svc that ingress is on, so I'd prefer to leave the doc in service side.

oliviassss commented 4 weeks ago

Closing this issue as for now, please feel free to reopen if any follow-up questions. Thanks