kubernetes-sigs / aws-load-balancer-controller

A Kubernetes controller for Elastic Load Balancers
https://kubernetes-sigs.github.io/aws-load-balancer-controller/
Apache License 2.0
3.82k stars 1.41k forks source link

Improve Prometheus Metrics #3716

Open kevarr opened 1 month ago

kevarr commented 1 month ago

Is your feature request related to a problem?

I couldn't find any documentation for what metrics the "metrics-server" port exposes.

Additionally, I couldn't configure the Helm Chart to not scrape these metrics, as my scrape_configs are looking at the prometheus.io/* annotations and these cannot be removed without enabling a ServiceMonitor.

Describe the solution you'd like

Describe alternatives you've considered

N/A

kevarr commented 1 month ago

Related https://github.com/kubernetes-sigs/aws-load-balancer-controller/issues/3244

huangm777 commented 1 month ago

Thank you for raising the issue! We will be taking a look at it, and of course we also welcome any community contributions to address the issue as well.

kevarr commented 1 month ago

Thanks @huangm777, ended up finding some metrics I could use, namely the aws_api ones. Still I think I would benefit from having some of these documented. When I find time I'll try to open a PR for this