prevent controller runtime complaining about SetupLogger() was never … - Githubissues

kubernetes-sigs / aws-load-balancer-controller

A Kubernetes controller for Elastic Load Balancers

https://kubernetes-sigs.github.io/aws-load-balancer-controller/

Apache License 2.0

3.89k stars 1.45k forks source link

prevent controller runtime complaining about SetupLogger() was never … #3724

Closed oliviassss closed 4 months ago

oliviassss commented 4 months ago

…called

Issue

fix the error message in e2e test logs that the controller runtime complains about SetupLogger() was never called

[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.

reference: https://github.com/solo-io/gloo/pull/8549

Description

Checklist

[ ] Added tests that cover your change (if possible)
[ ] Added/modified documentation as required (such as the README.md, or the docs directory)
[ ] Manually tested
[ ] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

[ ] Backfilled missing tests for code in same general area :tada:
[ ] Refactored something and made the world a better place :star2:

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/OWNERS)~~ [M00nF1sh,oliviassss] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment