search

kubernetes-sigs / aws-load-balancer-controller

A Kubernetes controller for Elastic Load Balancers
https://kubernetes-sigs.github.io/aws-load-balancer-controller/
Apache License 2.0
3.82k stars 1.41k forks source link

AWS NLB - Proxy Protocol v2 not disabled after removing related service annotation #3746

Closed matthew-walters closed 2 weeks ago

matthew-walters commented 2 weeks ago

Describe the bug Removed annotation service.beta.kubernetes.io/aws-load-balancer-proxy-protocol: "*" from my k8s LoadBalancer service, observed the target groups still had Proxy protocol v2: On

I see in the source code, it never sets to false: https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/ac21af638efdbf378f194b88ed12b70b5b0ae50a/pkg/service/model_build_target_group.go#L218-L224

Steps to reproduce Remove annotation service.beta.kubernetes.io/aws-load-balancer-proxy-protocol: "*" from a K8s load balancer service, observe the target group doesn't receive the update.

Expected outcome I expect target group to get updated to Proxy protocol v2: Off

Environment

matthew-walters commented 2 weeks ago

it actually appears to be an env issue as I cannot reproduce in a different env.