Feat(performance): Accept protobuf responses from kube-apiserver

marinoborges commented 1 week ago

Issue

Currently the controller only accepts the JSON responses from kube-apiserver. Accepting the more efficient Protobuf representation responses will improve performance at scale. This affects majorly the Pod cache ListWatch that is set here and can act as a bottleneck in clusters with large amount of pods.

By default, Kubernetes returns objects serialized to JSON with content type application/json. This is the default serialization format for the API. However, clients may request the more efficient Protobuf representation of these objects for better performance at scale.

More details in k8s doc page.

Description

Added a new flag accept-protobuf-content-type-enabled - default to false for compatibility with current behavior
Added documentation for the new flag
Added helm support for the new flag

Checklist

[ ] Added tests that cover your change (if possible)
[X] Added/modified documentation as required (such as the README.md, or the docs directory)
[X] Manually tested
[X] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

[ ] Backfilled missing tests for code in same general area :tada:
[ ] Refactored something and made the world a better place :star2:

k8s-ci-robot commented 1 week ago

Hi @marinoborges. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marinoborges Once this PR has been reviewed and has the lgtm label, please assign johngmyers for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-sigs / aws-load-balancer-controller