search

kubernetes-sigs / aws-load-balancer-controller

A Kubernetes controller for Elastic Load Balancers
https://kubernetes-sigs.github.io/aws-load-balancer-controller/
Apache License 2.0
3.96k stars 1.47k forks source link

Conditions to Ignore specific ReadinessGate control #3753

Closed marlonramos51 closed 2 weeks ago

marlonramos51 commented 5 months ago

Is your feature request related to a problem? Yes, in my company we developed a blue/green deploy related to infrastructure major changes due to internal process. We have 4 different repositories to deploy: infra eks cluster-blue, infra eks cluster-green, network stack (Elbs, targets, route, etc) and application

To make it simple, let´s say we have 1 single NLB and 2 target groups, TG-BLUE /TG-GREEN and the blue one is the active cluster and its target is attached to NLB. When I want to activate the other cluster, I switch from TG-BLUE to TG-GREEN in NLB. So, ever one Target is attached do NLB and the other one remain with no NLB attached.

If the readinessgate is enabled and I try deploy the application to that cluster whose target group is not yet attached to the NLB , the readiness workflow never ends due to the message "Target group is not configured to receive traffic"

Describe the solution you'd like I´d like to have a way to write some conditions when enable elbv2.k8s.aws/pod-readiness-gate-inject to allow the albcontroller ignore specific status, for instance: apiVersion: v1 kind: Namespace metadata: name: default labels: elbv2.k8s.aws/pod-readiness-gate-inject: enable conditions: status not in "No traffic"

Describe alternatives you've considered None, -leave a fake NLB just to have both targets ever attached is not an option -I don´t want to use instance as target backend

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 weeks ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 2 weeks ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/aws-load-balancer-controller/issues/3753#issuecomment-2484519528): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.