kubernetes-sigs / aws-load-balancer-controller

A Kubernetes controller for Elastic Load Balancers
https://kubernetes-sigs.github.io/aws-load-balancer-controller/
Apache License 2.0
3.88k stars 1.44k forks source link

Make `leaseDurationSeconds` of a lease owned by AWS Load Balancer Controller configurable #3823

Open gjbravi opened 2 weeks ago

gjbravi commented 2 weeks ago

Is your feature request related to a problem? Yes, sometimes the default lease duration time of 15s of the lease aws-load-balancer-controller-leader is too high.

Describe the solution you'd like I would like to configure the leaseDurationSeconds of a lease owned by AWS Load Balancer Controller.

Describe alternatives you've considered Controller-runtime already provides a way of configuring LeaseTime of a Lease in here.

shraddhabang commented 2 weeks ago

Hello @gjbravi , I agree. This would be a good feature to implement on the controller. Thank you for bringing this to our attention. I am marking this as a good-first-issue. We welcome any community contributions for such issues.

caiofralmeida commented 2 weeks ago

@gjbravi, it would be a good idea for us to contribute to the implementation, what do you think?

gjbravi commented 2 weeks ago

For sure @caiofralmeida.

@shraddhabang that's awesome, we're gonna work on that.