enable http and https listener attributes

wweiwei-li commented 4 days ago

Description

Improvement: setting attributes on IngressClassParam should resolve the conflicts in ingress group.
Enabled Http and Https listener attributes. alb.ingress.kubernetes.io/listener-attributes.${Protocol}-{Port} annotation, which allows dynamically configuration of protocol and port. With the combination of protocol and port, it serves as a unique identifier, enabling us to identify the listener and set attributes to it accordingly. For example, set alb.ingress.kubernetes.io/listener-attributes.HTTPS-443 : routing.http.response.server.enabled=true.

Also, new IngressClassParams spec listeners, allowing set listener attributes at ingress class level. For example

listeners:
- protocol: HTTPS
  port: 443
  listenerAttributes:
    - key: routing.http.response.server.enabled
      value: "true"

Checklist

[x] Added tests that cover your change (if possible)
[x] Added/modified documentation as required (such as the README.md, or the docs directory)
[x] Manually tested
[x] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

[ ] Backfilled missing tests for code in same general area :tada:
[ ] Refactored something and made the world a better place :star2:

shraddhabang commented 4 days ago

/lgtm /approved

k8s-ci-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wweiwei-li, zac-nixon Once this PR has been reviewed and has the lgtm label, please assign m00nf1sh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-sigs / aws-load-balancer-controller