search

kubernetes-sigs / azuredisk-csi-driver

Azure Disk CSI Driver
Apache License 2.0
147 stars 193 forks source link

feat: add tagValueDelimiter parameter #2388

Closed umagnus closed 4 months ago

umagnus commented 4 months ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: add tag value delimieter parameter and allow tag values containing commas and equal sign referring to issue https://github.com/kubernetes-sigs/azuredisk-csi-driver/issues/2323

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none
k8s-ci-robot commented 4 months ago

Hi @umagnus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
feiskyer commented 4 months ago

/ok-to-test

umagnus commented 4 months ago

/retest

umagnus commented 4 months ago

/retest

umagnus commented 4 months ago

/retest

umagnus commented 4 months ago

/retest

andyzhangx commented 4 months ago

@umagnus pls also squash all commits, thx

andyzhangx commented 4 months ago

/retest

k8s-ci-robot commented 4 months ago

@umagnus: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess d58e00cb3c185acbc4a710ac0266778fbbec687b link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, umagnus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 4 months ago

/cherrypick release-1.30

andyzhangx commented 4 months ago

/cherrypick release-1.29

k8s-infra-cherrypick-robot commented 4 months ago

@andyzhangx: new pull request created: #2396

In response to [this](https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2388#issuecomment-2216605511): >/cherrypick release-1.30 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 4 months ago

@andyzhangx: #2388 failed to apply on top of branch "release-1.29":

Applying: add tag value delimiter
Using index info to reconstruct a base tree...
M   pkg/azureconstants/azure_constants.go
M   pkg/azuredisk/controllerserver.go
M   pkg/azuredisk/controllerserver_test.go
M   pkg/azuredisk/controllerserver_v2.go
M   pkg/azureutils/azure_disk_utils.go
M   test/e2e/testsuites/dynamically_provisioned_azuredisk_tag_tester.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/testsuites/dynamically_provisioned_azuredisk_tag_tester.go
Auto-merging pkg/azureutils/azure_disk_utils.go
Auto-merging pkg/azuredisk/controllerserver_v2.go
Auto-merging pkg/azuredisk/controllerserver_test.go
Auto-merging pkg/azuredisk/controllerserver.go
Auto-merging pkg/azureconstants/azure_constants.go
CONFLICT (content): Merge conflict in pkg/azureconstants/azure_constants.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add tag value delimiter
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2388#issuecomment-2216605694): >/cherrypick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.