kubernetes-sigs / azuredisk-csi-driver

Azure Disk CSI Driver
Apache License 2.0
147 stars 192 forks source link

[release-1.29] fix: add pv patch permission with HonorPVReclaimPolicy enabled #2441

Closed andyzhangx closed 3 months ago

andyzhangx commented 3 months ago

What type of PR is this? /kind bug

What this PR does / why we need it: fix: add pv patch permission with HonorPVReclaimPolicy enabled

cherrypick of https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2439

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: add pv patch permission with HonorPVReclaimPolicy enabled
k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/release-1.29/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 3 months ago

/retest

andyzhangx commented 3 months ago

/retest

k8s-ci-robot commented 3 months ago

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-e2e-capz-windows-2022 82993270234bd7846fc870e321aa2581a5af1145 link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2022

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
andyzhangx commented 3 months ago

/retest