search

kubernetes-sigs / azuredisk-csi-driver

Azure Disk CSI Driver
Apache License 2.0
147 stars 193 forks source link

fix: create snapshot failure in edge zone #2450

Closed andyzhangx closed 3 months ago

andyzhangx commented 3 months ago

What type of PR is this? /kind bug

What this PR does / why we need it: fix: create snapshot failure in edge zone

``` I0801 17:27:57.425602 1 utils.go:77] GRPC call: /csi.v1.Controller/CreateSnapshot I0801 17:27:57.425628 1 utils.go:78] GRPC request: {"name":"snapshot-ec660e34-1f38-41de-9b1a-093aee63d751","source_volume_id":"/subscriptions/xxx/resourceGroups/mc_e2erg-ebld99563156-pzypqanubzn_e2eaks-qpj_westus/providers/Microsoft.Compute/disks/pvc-54b33ee8-ab52-444e-874e-82845edf6564"} I0801 17:27:57.425862 1 controllerserver.go:986] begin to create snapshot(snapshot-ec660e34-1f38-41de-9b1a-093aee63d751, incremental: true) under rg(mc_e2erg-ebld99563156-pzypqanubzn_e2eaks-qpj_westus) region(westus) I0801 17:27:57.765070 1 azure_armclient.go:301] Received error in sendAsync.send: resourceID: http://localhost:7788/subscriptions/xxx/resourceGroups/mc_e2erg-ebld99563156-pzypqanubzn_e2eaks-qpj_westus/providers/Microsoft.Compute/snapshots/snapshot-ec660e34-1f38-41de-9b1a-093aee63d751?api-version=2022-03-02 , error: Retriable: false, RetryAfter: 0s, HTTPStatusCode: 400, RawError: { "error": { "code": "InvalidParameter", "message": "The ExtendedLocation '' of the target resource does not match the ExtendedLocation 'losangeles' of the source resource.", "target": "extendedLocation" } } I0801 17:27:57.765106 1 azure_armclient.go:548] Received error in put.send: resourceID: /subscriptions/xxx/resourceGroups/mc_e2erg-ebld99563156-pzypqanubzn_e2eaks-qpj_westus/providers/Microsoft.Compute/snapshots/snapshot-ec660e34-1f38-41de-9b1a-093aee63d751, error: Retriable: false, RetryAfter: 0s, HTTPStatusCode: 400, RawError: { "error": { "code": "InvalidParameter", "message": "The ExtendedLocation '' of the target resource does not match the ExtendedLocation 'losangeles' of the source resource.", "target": "extendedLocation" } } I0801 17:27:57.765145 1 azure_snapshotclient.go:245] Received error in snapshot.put.request: resourceID: /subscriptions/xxx/resourceGroups/mc_e2erg-ebld99563156-pzypqanubzn_e2eaks-qpj_westus/providers/Microsoft.Compute/snapshots/snapshot-ec660e34-1f38-41de-9b1a-093aee63d751, error: Retriable: false, RetryAfter: 0s, HTTPStatusCode: 400, RawError: { "error": { "code": "InvalidParameter", "message": "The ExtendedLocation '' of the target resource does not match the ExtendedLocation 'losangeles' of the source resource.", "target": "extendedLocation" } } I0801 17:27:57.765293 1 azure_metrics.go:115] "Observed Request Latency" latency_seconds=0.33944254 request="azuredisk_csi_driver_controller_create_snapshot" resource_group="mc_e2erg-ebld99563156-pzypqanubzn_e2eaks-qpj_westus" subscription_id="xxx" source="disk.csi.azure.com" source_resource_id="/subscriptions/xxx/resourceGroups/mc_e2erg-ebld99563156-pzypqanubzn_e2eaks-qpj_westus/providers/Microsoft.Compute/disks/pvc-54b33ee8-ab52-444e-874e-82845edf6564" snapshot_name="snapshot-ec660e34-1f38-41de-9b1a-093aee63d751" result_code="failed_csi_driver_controller_create_snapshot" E0801 17:27:57.765321 1 utils.go:82] GRPC error: rpc error: code = Internal desc = create snapshot error: Retriable: false, RetryAfter: 0s, HTTPStatusCode: 400, RawError: { "error": { "code": "InvalidParameter", "message": "The ExtendedLocation '' of the target resource does not match the ExtendedLocation 'losangeles' of the source resource.", "target": "extendedLocation" } } ```

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none
k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 3 months ago

/retest

andyzhangx commented 3 months ago

/retest

andyzhangx commented 3 months ago

/retest

andyzhangx commented 3 months ago

/retest

andyzhangx commented 3 months ago

/retest

andyzhangx commented 3 months ago

/retest

andyzhangx commented 3 months ago

/retest

k8s-ci-robot commented 3 months ago

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-e2e-capz-windows-2022 74dfd5fc2cd8918bc572c95385c58ccf5e3abd89 link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2022
pull-azuredisk-csi-driver-e2e-capz-vmssflex 74dfd5fc2cd8918bc572c95385c58ccf5e3abd89 link true /test pull-azuredisk-csi-driver-e2e-capz-vmssflex

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
andyzhangx commented 3 months ago

/cherrypick release-1.30

andyzhangx commented 3 months ago

/cherrypick release-1.29

andyzhangx commented 3 months ago

/cherrypick release-1.28

k8s-infra-cherrypick-robot commented 3 months ago

@andyzhangx: new pull request created: #2451

In response to [this](https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2450#issuecomment-2265222702): >/cherrypick release-1.30 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 3 months ago

@andyzhangx: #2450 failed to apply on top of branch "release-1.29":

Applying: fix: create snapshot failure in edge zone
Applying: chore: add logs for edge zone setting
Using index info to reconstruct a base tree...
A   pkg/azuredisk/azure_managedDiskController.go
M   pkg/azuredisk/controllerserver.go
Falling back to patching base and 3-way merge...
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_managedDiskController.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_managedDiskController.go
Auto-merging pkg/azuredisk/controllerserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 chore: add logs for edge zone setting
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2450#issuecomment-2265222832): >/cherrypick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 3 months ago

@andyzhangx: #2450 failed to apply on top of branch "release-1.28":

Applying: fix: create snapshot failure in edge zone
Applying: chore: add logs for edge zone setting
Using index info to reconstruct a base tree...
A   pkg/azuredisk/azure_managedDiskController.go
M   pkg/azuredisk/controllerserver.go
Falling back to patching base and 3-way merge...
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_managedDiskController.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_managedDiskController.go
Auto-merging pkg/azuredisk/controllerserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 chore: add logs for edge zone setting
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2450#issuecomment-2265222945): >/cherrypick release-1.28 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.