search

kubernetes-sigs / azuredisk-csi-driver

Azure Disk CSI Driver
Apache License 2.0
147 stars 192 forks source link

fix: only enable removeNotReadyTaint on driver node daemonset #2456

Closed andyzhangx closed 3 months ago

andyzhangx commented 3 months ago

What type of PR is this? /kind bug

What this PR does / why we need it: fix: only enable removeNotReadyTaint on driver node daemonset

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: only enable removeNotReadyTaint on node daemonset
k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 3 months ago

/retest

k8s-ci-robot commented 3 months ago

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-e2e-migration-windows 99077a0171c23551bb51e09ac7df39efdc2a5df8 link true /test pull-azuredisk-csi-driver-e2e-migration-windows
pull-azuredisk-csi-driver-e2e-capz-vmssflex 99077a0171c23551bb51e09ac7df39efdc2a5df8 link true /test pull-azuredisk-csi-driver-e2e-capz-vmssflex
pull-azuredisk-csi-driver-external-e2e-single-az 99077a0171c23551bb51e09ac7df39efdc2a5df8 link true /test pull-azuredisk-csi-driver-external-e2e-single-az
pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess 99077a0171c23551bb51e09ac7df39efdc2a5df8 link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess
pull-azuredisk-csi-driver-e2e-capz 99077a0171c23551bb51e09ac7df39efdc2a5df8 link true /test pull-azuredisk-csi-driver-e2e-capz
pull-azuredisk-csi-driver-e2e-capz-windows-2022-hostprocess 99077a0171c23551bb51e09ac7df39efdc2a5df8 link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2022-hostprocess
pull-azuredisk-csi-driver-e2e-capz-windows-2022 99077a0171c23551bb51e09ac7df39efdc2a5df8 link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2022

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
andyzhangx commented 3 months ago

/cherrypick release-1.30

andyzhangx commented 3 months ago

/cherrypick release-1.29

k8s-infra-cherrypick-robot commented 3 months ago

@andyzhangx: new pull request created: #2459

In response to [this](https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2456#issuecomment-2272874792): >/cherrypick release-1.30 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 3 months ago

@andyzhangx: #2456 failed to apply on top of branch "release-1.29":

Applying: fix: only enable removeNotReadyTaint on node daemonset
Using index info to reconstruct a base tree...
M   pkg/azuredisk/azuredisk.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azuredisk/azuredisk.go
CONFLICT (content): Merge conflict in pkg/azuredisk/azuredisk.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: only enable removeNotReadyTaint on node daemonset
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2456#issuecomment-2272874956): >/cherrypick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.