search

kubernetes-sigs / azuredisk-csi-driver

Azure Disk CSI Driver
Apache License 2.0
147 stars 193 forks source link

chore: set HostProcess container deployment on Windows as default #2457

Closed andyzhangx closed 3 months ago

andyzhangx commented 3 months ago

What type of PR is this? /kind feature

What this PR does / why we need it: chore: set HostProcess container deployment on Windows as default

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none
k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 months ago

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-e2e-capz-vmssflex a44ace461b8204e5b88cd087ed803b87cb5a670c link true /test pull-azuredisk-csi-driver-e2e-capz-vmssflex
pull-azuredisk-csi-driver-e2e-capz-windows-2022-hostprocess a44ace461b8204e5b88cd087ed803b87cb5a670c link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2022-hostprocess
pull-azuredisk-csi-driver-e2e-capz-windows-2022 a44ace461b8204e5b88cd087ed803b87cb5a670c link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2022
pull-azuredisk-csi-driver-external-e2e-single-az a44ace461b8204e5b88cd087ed803b87cb5a670c link true /test pull-azuredisk-csi-driver-external-e2e-single-az
pull-azuredisk-csi-driver-e2e-migration-windows a44ace461b8204e5b88cd087ed803b87cb5a670c link true /test pull-azuredisk-csi-driver-e2e-migration-windows
pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess a44ace461b8204e5b88cd087ed803b87cb5a670c link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
andyzhangx commented 3 months ago

/cherrypick release-1.30

k8s-infra-cherrypick-robot commented 3 months ago

@andyzhangx: #2457 failed to apply on top of branch "release-1.30":

Applying: chore: set HostProcess container deployment on Windows as default
Using index info to reconstruct a base tree...
M   charts/README.md
A   charts/latest/azuredisk-csi-driver-v0.0.0.tgz
M   charts/latest/azuredisk-csi-driver/values.yaml
Falling back to patching base and 3-way merge...
Auto-merging charts/latest/azuredisk-csi-driver/values.yaml
CONFLICT (modify/delete): charts/latest/azuredisk-csi-driver-v0.0.0.tgz deleted in HEAD and modified in chore: set HostProcess container deployment on Windows as default. Version chore: set HostProcess container deployment on Windows as default of charts/latest/azuredisk-csi-driver-v0.0.0.tgz left in tree.
Auto-merging charts/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 chore: set HostProcess container deployment on Windows as default
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2457#issuecomment-2272430773): >/cherrypick release-1.30 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.