search

kubernetes-sigs / azuredisk-csi-driver

Azure Disk CSI Driver
Apache License 2.0
147 stars 192 forks source link

feat: add extra-create-metadata=true on snapshot sidecar #2532

Closed andyzhangx closed 2 months ago

andyzhangx commented 2 months ago

What type of PR is this? /kind feature

What this PR does / why we need it: feat: add extra-create-metadata=true on snapshot sidecar

The CSI snapshotter has a new --extra-create-metadata flag. When set to true, the name and namespace of the source VolumeSnapshot, and the name of the source VolumeSnapshotContent will be passed as parameters to the CSI driver in CreateSnapshotRequest.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

``` I0920 11:51:14.280741 1 utils.go:105] GRPC call: /csi.v1.Controller/CreateSnapshot I0920 11:51:14.280762 1 utils.go:106] GRPC request: {"name":"snapshot-e326e8ec-d067-47c3-ac3d-20e895114c21","parameters":{"csi.storage.k8s.io/volumesnapshot/name":"snapshot-dbz7p","csi.storage.k8s.io/volumesnapshot/namespace":"snapshotting-8511","csi.storage.k8s.io/volumesnapshotcontent/name":"snapcontent-e326e8ec-d067-47c3-ac3d-20e895114c21"},"source_volume_id":"/subscriptions/46678f10-4bbb-447e-98e8-d2829589f2d8/resourceGroups/capz-jzif9q/providers/Microsoft.Compute/disks/pvc-965a1e7d-5315-4482-96d5-99c44cd36262"} E0920 11:51:14.280910 1 utils.go:110] GRPC error: rpc error: code = Internal desc = AzureDisk - invalid option csi.storage.k8s.io/volumesnapshot/namespace in VolumeSnapshotClass ```

Release note:

feat: add extra-create-metadata=true on snapshot sidecar
k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 2 months ago

/retest

andyzhangx commented 2 months ago

/retest

k8s-ci-robot commented 2 months ago

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-external-e2e-single-az 0044ec7a78b68e3ad077d8b06dd329fbed292ec6 link true /test pull-azuredisk-csi-driver-external-e2e-single-az
pull-azuredisk-csi-driver-e2e-capz-windows-2022-hostprocess 0044ec7a78b68e3ad077d8b06dd329fbed292ec6 link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2022-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).