[release-1.30] feat: add pre-defined tags in snapshot creation

kubernetes-sigs / azuredisk-csi-driver

Azure Disk CSI Driver

Apache License 2.0

147 stars 192 forks source link

[release-1.30] feat: add pre-defined tags in snapshot creation #2564

Closed andyzhangx closed 1 month ago

andyzhangx commented 1 month ago

What type of PR is this? /kind feature

What this PR does / why we need it:

cherrypick of https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2561 feat: add pre-defined tags in snapshot creation, this PR would add following tags in snapshot creation:

k8s-azure-created-by: kubernetes-azure-dd
kubernetes.io-created-for-snapshot-namespace: namespace
kubernetes.io-created-for-snapshot-name: name
source_volume_id:/subscriptions/xxx/resourceGroups/capz-kiobac/providers/Microsoft.Compute/disks/xxx

Which issue(s) this PR fixes:

Fixes #

Requirements:

[ ] uses conventional commit messages
[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:

Release note:

feat: add pre-defined tags in snapshot creation

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/release-1.30/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

andyzhangx commented 1 month ago

/retest

andyzhangx commented 1 month ago

/retest

k8s-ci-robot commented 1 month ago

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-azuredisk-csi-driver-external-e2e-single-az	4309395ee34f91fd18b439a2a276011d11ff575e	link	true	`/test pull-azuredisk-csi-driver-external-e2e-single-az`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).