kubernetes-sigs / azuredisk-csi-driver

Azure Disk CSI Driver
Apache License 2.0
147 stars 193 forks source link

fix: support attach operations after premiumV2 disk migration #2569

Closed landreasyan closed 1 month ago

landreasyan commented 1 month ago

What type of PR is this?

What this PR does / why we need it: Customers can use VAC to migrate PremiumLRS disks to PremiumV2LRS disks while they are detached from the VM. While the driver already sets caching mode to None when it creates a PremiumV2LRS disk, it still defaults to either the caching mode set in the VolumeContext or to ReadOnly caching when it attaches the disk. Because caching in the VolumeContext defaults and is set to ReadOnly for PremiumLRS disks, to support attach operation after the migration, the driver must set the caching mode to None explicitly when it attaches a PremiumV2LRS disk.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none
linux-foundation-easycla[bot] commented 1 month ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, landreasyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 month ago

@landreasyan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-external-e2e-single-az 3b3ce0a30681e03f83f0feefd21447a174d4ff3a link true /test pull-azuredisk-csi-driver-external-e2e-single-az
pull-azuredisk-csi-driver-e2e-capz 3b3ce0a30681e03f83f0feefd21447a174d4ff3a link true /test pull-azuredisk-csi-driver-e2e-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
andyzhangx commented 1 month ago

/cherrypick release-1.31

andyzhangx commented 1 month ago

/cherrypick release-1.30

andyzhangx commented 1 month ago

/cherrypick release-1.29

andyzhangx commented 1 month ago

/cherrypick release-1.28

k8s-infra-cherrypick-robot commented 1 month ago

@andyzhangx: new pull request created: #2571

In response to [this](https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2569#issuecomment-2434457891): >/cherrypick release-1.31 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 1 month ago

@andyzhangx: new pull request created: #2572

In response to [this](https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2569#issuecomment-2434458018): >/cherrypick release-1.30 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 1 month ago

@andyzhangx: new pull request created: #2573

In response to [this](https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2569#issuecomment-2434458154): >/cherrypick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 1 month ago

@andyzhangx: new pull request created: #2574

In response to [this](https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2569#issuecomment-2434458272): >/cherrypick release-1.28 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.