search

kubernetes-sigs / azuredisk-csi-driver

Azure Disk CSI Driver
Apache License 2.0
147 stars 192 forks source link

fix: add correct userAgent for the driver #2570

Closed MartinForReal closed 1 month ago

MartinForReal commented 1 month ago

What type of PR is this? /kind cleanup

What this PR does / why we need it: chores: set useragent for e2e clients Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer: https://github.com/kubernetes/kubernetes/commit/9c92b37d4ed45427116e9ec2c27366199eea895c#diff-3145c766434ba7221bf0a6effe8f70bb744e9a214cac1d4a0ec5427414c0eecf move GenerateVolumeName to csi driver https://github.com/kubernetes/kubernetes/commit/f55588fa0b095bebc4f8d197dfb7ca3b6bb27fd7#diff-19f37de624b324e650f830dc887c4a5bba1831378790c62b09aee69a4ba0c2e9L302 test framework is updated. Release note:

none
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MartinForReal Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MartinForReal commented 1 month ago

/retest

MartinForReal commented 1 month ago

/retest

MartinForReal commented 1 month ago

/retest

k8s-ci-robot commented 1 month ago

@MartinForReal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-external-e2e-single-az aeb73ed88cca63bca07a085f9c447a2d16147221 link true /test pull-azuredisk-csi-driver-external-e2e-single-az
pull-azuredisk-csi-driver-e2e-capz-windows-2022 aeb73ed88cca63bca07a085f9c447a2d16147221 link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2022

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).