Closed bertinatto closed 2 years ago
per this PR(https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/607), it should work from v1.19, what's your k8s version? @bertinatto
This PR tries to skip node expansion when volume type is block. However, this does not guarantee to work well because volumeCapability is not yet being passed from kubelet until v1.19.
https://github.com/kubernetes/kubernetes/commit/7d6959ce2ce49fa5b37b3aa28d20fdeb01c02223
The root cause for this is the way it get devicePath. I am not familiar with this domain so I dont know how to get the devicepath given volumepath when we cant use the mount information.
[Update] I am using isBlock, err := hostutil.NewHostUtil().PathIsDevice(volumePath)
to check if this is a block device and it seems to work.
Testing: Running e2e testsuite offline volume expansion and it worked for block volume.
cc @boddumanohar
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/reopen
/remove-lifecycle rotten
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closing this issue.
fixed in v1.13.0 release
Does azuredisk support offline expansion?
I'm on 1.25.3 k8s version with 1.22 azuredisk and I see this test failing which was added in 1.25 release (kubernetes/kubernetes#109580).
Kubernetes e2e suite: TestStorageAzureDisk/e2e/[It] External Storage [Driver: disk.csi.azure.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand Verify if offline PVC expansion works
{Nov 28 17:23:44.290: while recreating pod for resizing: pod "pod-ac9cbfee-5807-431e-9229-7c85918e4f0d" is not Running: timed out while waiting for pod volume-expand-7639/pod-ac9cbfee-5807-431e-9229-7c85918e4f0d to be running failed test/e2e/storage/testsuites/volume_expand.go:242
k8s.io/kubernetes/test/e2e/storage/testsuites.(*volumeExpandTestSuite).DefineTests.func4()
test/e2e/storage/testsuites/volume_expand.go:242 +0xe5a}
Does azuredisk support offline expansion?
I'm on 1.25.3 k8s version with 1.22 azuredisk and I see this test failing which was added in 1.25 release (kubernetes/kubernetes#109580).
Kubernetes e2e suite: TestStorageAzureDisk/e2e/[It] External Storage [Driver: disk.csi.azure.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand Verify if offline PVC expansion works {Nov 28 17:23:44.290: while recreating pod for resizing: pod "pod-ac9cbfee-5807-431e-9229-7c85918e4f0d" is not Running: timed out while waiting for pod volume-expand-7639/pod-ac9cbfee-5807-431e-9229-7c85918e4f0d to be running failed test/e2e/storage/testsuites/volume_expand.go:242 k8s.io/kubernetes/test/e2e/storage/testsuites.(*volumeExpandTestSuite).DefineTests.func4() test/e2e/storage/testsuites/volume_expand.go:242 +0xe5a}
@AnishShah yes, it's supported, and azure disk also supports online resize now, I think you could run following commands to register online resize directly, with the registration, both offline and online resize would work.
az feature register --namespace Microsoft.Compute --name LiveResize
az feature show --namespace Microsoft.Compute --name LiveResize
What happened:
The test:
External Storage [Driver: disk.csi.azure.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand Verify if offline PVC expansion works
Fails with:
I believe this code isn't correctly recognizing the block volume.