search

kubernetes-sigs / azurefile-csi-driver

Azure File CSI Driver
Apache License 2.0
147 stars 136 forks source link

fix: allow more cache hit in GetRemoteServerFromTarget on hpc deployment #1940

Closed andyzhangx closed 2 weeks ago

andyzhangx commented 2 weeks ago

What type of PR is this? /kind feature

What this PR does / why we need it: fix: allow more cache hit in GetRemoteServerFromTarget on hpc deployment

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: allow more cache hit in GetRemoteServerFromTarget on hpc deployment
k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/azurefile-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 2 weeks ago

/retest

andyzhangx commented 2 weeks ago

/retest

andyzhangx commented 2 weeks ago

/cherrypick release-1.30

andyzhangx commented 2 weeks ago

/cherrypick release-1.29

andyzhangx commented 2 weeks ago

/cherrypick release-1.28

k8s-infra-cherrypick-robot commented 2 weeks ago

@andyzhangx: new pull request created: #1941

In response to [this](https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/1940#issuecomment-2184311197): >/cherrypick release-1.30 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 2 weeks ago

@andyzhangx: new pull request created: #1942

In response to [this](https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/1940#issuecomment-2184311240): >/cherrypick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 2 weeks ago

@andyzhangx: #1940 failed to apply on top of branch "release-1.28":

Applying: fix: allow more cache hit in GetRemoteServerFromTarget on hpc deployment
Using index info to reconstruct a base tree...
M   pkg/os/smb/smb.go
M   pkg/util/util.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/util/util.go
CONFLICT (content): Merge conflict in pkg/util/util.go
Auto-merging pkg/os/smb/smb.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: allow more cache hit in GetRemoteServerFromTarget on hpc deployment
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/1940#issuecomment-2184311273): >/cherrypick release-1.28 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
andyzhangx commented 2 weeks ago

/cherrypick release-1.28

k8s-infra-cherrypick-robot commented 2 weeks ago

@andyzhangx: #1940 failed to apply on top of branch "release-1.28":

Applying: fix: allow more cache hit in GetRemoteServerFromTarget on hpc deployment
Using index info to reconstruct a base tree...
M   pkg/os/smb/smb.go
M   pkg/util/util.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/util/util.go
CONFLICT (content): Merge conflict in pkg/util/util.go
Auto-merging pkg/os/smb/smb.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: allow more cache hit in GetRemoteServerFromTarget on hpc deployment
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/1940#issuecomment-2184312910): >/cherrypick release-1.28 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.